8368846: java/io/File/createTempFile/TargetDirectory fails when run by root user #27542

fandreuz · 2025-09-29T08:28:38Z

The test checks whether writing to a read-only directory throws a IOException. This test is not applicable when the user running the test is root. Thus, I propose to skip it.

I converted the class to several JUnit tests, so we can use @DisabledIf.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8368846: java/io/File/createTempFile/TargetDirectory fails when run by root user (Enhancement - P4)

Reviewers

Brian Burkhalter (@bplb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27542/head:pull/27542
$ git checkout pull/27542

Update a local copy of the PR:
$ git checkout pull/27542
$ git pull https://git.openjdk.org/jdk.git pull/27542/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27542

View PR using the GUI difftool:
$ git pr show -t 27542

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27542.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-09-29T08:31:02Z

👋 Welcome back fandreuzzi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-09-29T08:31:20Z

@fandreuz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368846: java/io/File/createTempFile/TargetDirectory fails when run by root user

Reviewed-by: bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

b00720e: 8369419: Error reporting of JFR JNI method registration crash on MacOSX
b6e5ef4: 8360373: src/java.base/share/classes/sun/security/util/Debug.java implement negative testing
be10722: 8366847: JFR reports incorrect number of cores on hybrid CPU
... and 21 more: https://git.openjdk.org/jdk/compare/9def7bfea263f6f77f0bd9d4c16f00b7a0834243...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@bplb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2025-09-29T08:31:58Z

@fandreuz The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-09-29T08:35:35Z

Webrevs

01: Full - Incremental (8b828646)
00: Full (1a0b5065)

bplb · 2025-10-08T23:26:41Z

test/jdk/java/io/File/createTempFile/TargetDirectory.java

 * @bug 4847239
 * @summary Verify directory parameter behavior in File.createTempFile(String,String,File)
+ * @library /test/lib
+ * @run junit/othervm TargetDirectory


Is othervm needed here?

Not really, fixed

bplb · 2025-10-08T23:31:08Z

test/jdk/java/io/File/createTempFile/TargetDirectory.java

+
+class TargetDirectory {
+
+    @TempDir


In my testing I saw this output for each of the four sub-tests:

INFO: Skipping cleanup of temp dir [...] for field TargetDirectory.tempDir due to CleanupMode.NEVER.

Should this have CleanupMode.ALWAYS? In the old version of the test there were explcit calls to File.delete.

Fixed, thanks

bplb · 2025-10-08T23:45:07Z

test/jdk/java/io/File/createTempFile/TargetDirectory.java

-    public static void main(String[] args) throws Exception {
-        // Target directory exists and is writable
-        Path dir = Path.of("target");
+import static org.junit.jupiter.api.Assertions.*;


I think you can dispense with the wild card at line 50 by doing:

import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertTrue;

RogerRiggs · 2025-10-09T14:28:38Z

test/jdk/java/io/File/createTempFile/TargetDirectory.java

+    }
+
+    @Test
+    @DisabledIf("jdk.test.lib.Platform#isRoot")


This will silently skip the test.
Jtreg has a feature for keeping track of Skipped tests and reporting they were skipped.
Throwing SkippedException would enable that reporting.
Take a look at a similar test: test/jdk/java/io/File/SetAccess.java

This will silently skip the test.

I ran the test as root and as my normal user. For the normal user one gets

STARTED TargetDirectory::testReadOnlyDirectory 'testReadOnlyDirectory()'

whereas for root

SKIPPED TargetDirectory::testReadOnlyDirectory 'testReadOnlyDirectory()' @DisabledIf("jdk.test.lib.Platform#isRoot") evaluated to true

which looked okay to me.

bplb

Looks good now.

fandreuz · 2025-10-10T07:48:43Z

Thanks for the review @RogerRiggs and @bplb.

fandreuz · 2025-10-10T07:48:48Z

/integrate

openjdk · 2025-10-10T07:50:29Z

@fandreuz
Your change (at version 8b82864) is now ready to be sponsored by a Committer.

bplb · 2025-10-10T15:36:35Z

/sponsor

openjdk · 2025-10-10T15:39:31Z

Going to push as commit fc49a1b.
Since your change was applied there have been 31 commits pushed to the master branch:

f6d77cb: 8347555: [REDO] C2: implement optimization for series of Add of unique value
5594d6b: 8368522: (fs) BasicFileAttributes Linux musl 1.2.5 incompatibility with statx
afda8ad: 8369501: Parallel: Add UseAdaptiveSizePolicy requirement to TestDynShrinkHeap.java
... and 28 more: https://git.openjdk.org/jdk/compare/9def7bfea263f6f77f0bd9d4c16f00b7a0834243...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-10-10T15:39:46Z

@bplb @fandreuz Pushed as commit fc49a1b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

fandreuz added 3 commits September 28, 2025 13:40

convert to junit and skip

44eb770

cc

049bcce

nn

1a0b506

openjdk bot added the core-libs [email protected] label Sep 29, 2025

openjdk bot added the rfr Pull request is ready for review label Sep 29, 2025

bplb reviewed Oct 8, 2025

View reviewed changes

RogerRiggs reviewed Oct 9, 2025

View reviewed changes

fandreuz added 2 commits October 10, 2025 00:25

Merge branch 'master' into JDK-8368846

9f82082

review

8b82864

bplb approved these changes Oct 10, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 10, 2025

openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 10, 2025

openjdk bot added the integrated Pull request has been integrated label Oct 10, 2025

openjdk bot closed this Oct 10, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 10, 2025

8368846: java/io/File/createTempFile/TargetDirectory fails when run by root user #27542

8368846: java/io/File/createTempFile/TargetDirectory fails when run by root user #27542

Uh oh!

Conversation

fandreuz commented Sep 29, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Sep 29, 2025

Uh oh!

openjdk bot commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge bot commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bplb left a comment

Choose a reason for hiding this comment

Uh oh!

fandreuz commented Oct 10, 2025

Uh oh!

fandreuz commented Oct 10, 2025

Uh oh!

openjdk bot commented Oct 10, 2025

Uh oh!

bplb commented Oct 10, 2025

Uh oh!

openjdk bot commented Oct 10, 2025

Uh oh!

openjdk bot commented Oct 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

fandreuz commented Sep 29, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Sep 29, 2025 •

edited

Loading

openjdk bot commented Sep 29, 2025 •

edited

Loading

mlbridge bot commented Sep 29, 2025 •

edited

Loading